Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error status code documentation a little bit. #5583

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Update error status code documentation a little bit. #5583

merged 1 commit into from
Mar 24, 2015

Conversation

brendandburns
Copy link
Contributor

@bgrant0607

Partially addresses #2174

bgrant0607
bgrant0607 reviewed Mar 18, 2015
View reviewed changes
docs/api-conventions.md
@@ -238,8 +238,6 @@ The following HTTP status codes may be returned by the API.

* `200 StatusOK`
* Indicates that the request completed successfully.
* `201 StatusCreated`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing 201?

We do return 201:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/integration/auth_test.go#L201

#2031

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@bgrant0607
Copy link
Member

Also, this doesn't close the issue. auth_test might be reasonably comprehensive, but we're not yet documenting status codes in the swagger, which we could.

@brendandburns
Copy link
Contributor Author

Ok, I thought with the removal of operations, we no longer returned 201.
I'll re-add it, and update the section on status to include delete.

Thanks
Brendan
On Mar 17, 2015 10:01 PM, "Brian Grant" notifications@github.com wrote:

Also, this doesn't close the issue. auth_test might be reasonably
comprehensive, but we're not yet documenting status codes in the swagger,
which we could.

—
Reply to this email directly or view it on GitHub
#5583 (comment)
.

@brendandburns
Copy link
Contributor Author

Comments addressed.

PTAL.
Thanks!
--brendan

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2015
saad-ali added a commit that referenced this pull request Mar 24, 2015
@saad-ali
Merge pull request #5583 from brendandburns/docs
959b3a4 
Update error status code documentation a little bit.
@saad-ali saad-ali merged commit 959b3a4 into kubernetes:master Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendandburns @bgrant0607 @googlebot @saad-ali