Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring scope to default GCE config. #5576

Merged
merged 1 commit into from
Mar 18, 2015
Merged

Add monitoring scope to default GCE config. #5576

merged 1 commit into from
Mar 18, 2015

Conversation

vmarmol
Copy link
Contributor

@vmarmol vmarmol commented Mar 18, 2015

This will allow Heapster to run GCM-based monitoring on the nodes.

@vmarmol
Add monitoring scope to default GCE config.
8e2dc04 
This will allow Heapster to run GCM-based monitoring on the nodes.
@vmarmol
Copy link
Contributor Author

vmarmol commented Mar 18, 2015

Cluster comes up as expected. Note that there is no alias for the monitoring scope which is why we use the full scope name.

@vishh
Copy link
Contributor

vishh commented Mar 18, 2015

LGTM

vishh added a commit that referenced this pull request Mar 18, 2015
@vishh
Merge pull request #5576 from vmarmol/auth
b6e7f47 
Add monitoring scope to default GCE config.
@vishh vishh merged commit b6e7f47 into kubernetes:master Mar 18, 2015
@vmarmol vmarmol deleted the auth branch March 18, 2015 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmarmol @vishh @googlebot