Garbage collecting images in the Kubelet. #5569
Merged
+61
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e2e is all green :) |
vmarmol
force-pushed
the
image-gc
branch
3 times, most recently
from
e9d0472 to
01ed372
Compare
| @@ -133,6 +136,8 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) { | |||
| fs.Var(&s.ClusterDNS, "cluster_dns", "IP address for a cluster DNS server. If set, kubelet will configure all containers to use this for DNS resolution in addition to the host's DNS servers") | |||
| fs.BoolVar(&s.ReallyCrashForTesting, "really_crash_for_testing", s.ReallyCrashForTesting, "If true, crash with panics more often.") | |||
| fs.DurationVar(&s.StreamingConnectionIdleTimeout, "streaming_connection_idle_timeout", 0, "Maximum time a streaming connection can be idle before the connection is automatically closed. Example: '5m'") | |||
| fs.IntVar(&s.ImageGCHighThresholdPercent, "image_gc_high_threshold", s.ImageGCHighThresholdPercent, "The percent of usage after which image garbage collection is always run. Default: 90%%") | |||
There was a problem hiding this comment.
Nit: s/usage/disk usage/ for clarity.
|
lgtm, but @dchen1107 or @saad-ali should probably look it over. |
| RegistryBurst: 10, | ||
| EnableDebuggingHandlers: true, | ||
| MinimumGCAge: 1 * time.Minute, | ||
| MaxPerPodContainerCount: 5, |
There was a problem hiding this comment.
Was MaxPerPodContainerCount removed on purpose?
There was a problem hiding this comment.
Good catch! It was not, that was an incorrect merge. Re-added.
Integrated the imageManager into the Kubelet and applies the garbage collection policy every 5 minutes. The default policy allows up to 90% disk usage, after which images are garbage collected to bring limit back down to 80%. Fixes kubernetes#157.
|
LGTM |
j3ffml
added
the
lgtm
|
LGTM |
dchen1107
added a commit
that referenced
this pull request
Mar 18, 2015
Garbage collecting images in the Kubelet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the imageManager into the Kubelet and applies the garbage
collection policy every 5 minutes. The default policy allows up to 90%
disk usage, after which images are garbage collected to bring limit back
down to 80%.
Fixes #157.