Fix vagrant so that ssh commands work OOTB #5557
Conversation
| # Here an individual provider can add extra tests, | ||
| # For example 'vagrant ssh master1 kubectl get pods' should work | ||
| # to show existing pods, and so on. | ||
| ${KUBE_ROOT}/cluster/${KUBERNETES_PROVIDER}/validate-provider.sh |
There was a problem hiding this comment.
You would need a shell file for each provider?
My bias is we do not do this piece since the goal is to move more of this into a Go program.
|
looks like build has passed now, i can rebase if you think its a good idea. |
|
No need to rebase. I am not sure I understand the value of the validate-cluster operation per provider right now as presented. It looks like something that will just make things slower. Is there any reason you can't move whatever additional verification you want to do in cluster/vagrant/util.sh verify-cluster function? |
|
you're right - that is a great place for it cluster/vagrant/util.sh , which seems to be serving as an interface . Somehow that completely skipped my mind . |
|
squash your commits |
jayunit100
force-pushed
the
vagrant-fix-1
branch
from
dec0e9a to
936ae7a
Compare
|
squashed a few and minimized the change, removed one extra file. I think this is something we can agree on. if this looks useful feel free to push, if not happy to close also.... |
|
I am not seeing the squash... I still see 5 commits where 1 commit would be appropriate - you are just changing 2 files and 7 lines ;-) |
|
hmmm funny, let me push again |
jayunit100
force-pushed
the
vagrant-fix-1
branch
from
936ae7a to
91b64b5
Compare
… vagrant/util.sh, remove run_provider_test, cleanup.
jayunit100
force-pushed
the
vagrant-fix-1
branch
from
91b64b5 to
9b67949
Compare
|
okay i just rebased /pushed :) |
|
Thanks ;-) |
Fix vagrant so that ssh commands work OOTB
This adds a provisioner specific unit testing framework, so that any provisioner can test its specific functionality.
It also fixes a particular bug for a particular provisioner which im particularly fond of :)