Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate code #55467

Merged
merged 1 commit into from
Dec 14, 2017
Merged

remove duplicate code #55467

merged 1 commit into from
Dec 14, 2017
+0 −78

Conversation

hzxuzhonghu
Copy link
Member

What this PR does / why we need it:

remove unused duplicate code

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

no impact on function

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2017
@brendandburns
Copy link
Contributor

/ok-to-test

If this is truly dead code, then LGTM, I guess we'll see if the unit tests run...

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2017
@hzxuzhonghu
Copy link
Member Author

@brendandburns This is really unused code.

@hzxuzhonghu
Copy link
Member Author

ping @brendandburns

@brendandburns
Copy link
Contributor

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, hzxuzhonghu

Associated issue requirement bypassed by: brendandburns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member Author

/retest

@brendandburns brendandburns added this to the v1.9 milestone Nov 29, 2017
@enisoc
Copy link
Member

enisoc commented Dec 2, 2017

This seems like it can wait until after the release. Let me know if you disagree.

@enisoc enisoc removed this from the v1.9 milestone Dec 2, 2017
@brendandburns brendandburns added this to the v1.9 milestone Dec 5, 2017
@jberkus jberkus mentioned this pull request Dec 6, 2017
Closed
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@brendandburns @hzxuzhonghu @lavalamp

Important: This pull request was missing labels required for the v1.9 milestone for more than 3 days:

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Dec 9, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55900, 55995, 55913, 55467, 55376). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 506e954 into kubernetes:master Dec 14, 2017
@hzxuzhonghu hzxuzhonghu deleted the security-context branch December 14, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/removed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hzxuzhonghu @brendandburns @k8s-github-robot @enisoc @fejta-bot @lavalamp @k8s-ci-robot