add get available versions commmand #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running: ./hack/verify-gendocs.sh fails - can you please fix it? |
| return strings.Join(apiVersions.Versions, ",") | ||
| } | ||
|
|
||
| func (apiVersions APIVersions) GoString() string { |
There was a problem hiding this comment.
This seems redundant with the above. Also I'm not seeing where either of these are used...
There was a problem hiding this comment.
@jlowdermilk
GoString is called here
this is a little more friendly
Otherwise it will print the APIVersions struct literally maybe like unversioned.APIVersions{Versions:[v1beta1 v1beta2 v1beta3]}
`
There was a problem hiding this comment.
Ah, thanks for explanation. That does look better.
|
Minor nit, otherwise lgtm. |
j3ffml
added
the
lgtm
j3ffml
added a commit
that referenced
this pull request
Mar 18, 2015
add get available versions commmand
|
Merged. Thanks, @you-n-g! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command
kubectl apiversionswill produce results below nowrefer to #5275