Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: Make swap check as an error #55399

Merged
merged 1 commit into from
Nov 9, 2017
Merged

kubeadm: Make swap check as an error #55399

merged 1 commit into from
Nov 9, 2017

Conversation

kad
Copy link
Member

@kad kad commented Nov 9, 2017 •
edited
Loading

What this PR does / why we need it:
Based on amount of support issues where warning about enabled
swap not noticed or ignored, it will be better to make this
check as an error.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
cc @luxas
attention @jpbetz : this change planned to be also cherrypicked to 1.8 branch.
/area kubeadm
/sig cluster-lifecycle

Release note:

kubeadm now produces error during preflight checks if swap is enabled. Users, who can setup kubelet to run in unsupported environment with enabled swap, will be able to skip that preflight check.

@kad
Make swap check as an error
2a1496c 
Based on amount of support issues where warning about enabled
swap not noticed or ignored, it will be better to make this
check as an error.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 9, 2017
@kad kad mentioned this pull request Nov 9, 2017
Merged
@luxas luxas added this to the v1.8 milestone Nov 9, 2017
luxas
luxas approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve no-issue

Thanks @kad for this!

cc @timothysc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kad, luxas

Associated issue requirement bypassed by: luxas

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017
@luxas luxas added cherrypick-candidate approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2017
@kad
Copy link
Member Author

kad commented Nov 9, 2017

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55380, 55399, 55377, 55055). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e8c659c into kubernetes:master Nov 9, 2017
k8s-github-robot pushed a commit that referenced this pull request Nov 11, 2017
Merge pull request #55402 from kad/automated-cherry-pick-of-#55399-or…
83ee5ba 
…igin-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55399

Cherry pick of #55399 on release-1.8.

#55399: Make swap check as an error
joshuaspence added a commit to joshuaspence/homelab-packer that referenced this pull request Dec 29, 2019
@joshuaspence
Disable swap
48cb78b 
See https://medium.com/nycdev/k8s-on-pi-9cc14843d43 and kubernetes/kubernetes#55399.
joshuaspence added a commit to joshuaspence/homelab-packer that referenced this pull request Jan 16, 2020
@joshuaspence
Disable swap
b2373b6 
See https://medium.com/nycdev/k8s-on-pi-9cc14843d43 and kubernetes/kubernetes#55399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

Assignees

@justinsb justinsb

@errordeveloper errordeveloper

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@kad @k8s-github-robot @luxas @justinsb @errordeveloper @jpbetz @k8s-ci-robot