Adding GetFieldSelector() to client.EventInterface #5532
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Verified that e2e tests pass :) |
|
Looks like @lavalamp is out this week. |
|
Sorry, I'm swamped. I suggest @saad-ali. |
|
I'll take a look |
| @@ -41,6 +41,8 @@ type EventInterface interface { | |||
| // Search finds events about the specified object | |||
| Search(objOrRef runtime.Object) (*api.EventList, error) | |||
| Delete(name string) error | |||
| // Returns the appropriate field selector based on the API version being used to communicate with the server. | |||
| GetFieldSelector(involvedObjectName, involvedObjectNamespace, involvedObjectKind, involvedObjectUID *string) labels.Selector | |||
There was a problem hiding this comment.
I think this comment would be little clearer:
Returns a field selector that can be used to filter List and Watch queries to return only events about the specified object.
There was a problem hiding this comment.
Updated the comment.
|
LGTM mod a few nits |
|
Thanks! |
|
LGTM. Will merge on green. |
Adding GetFieldSelector() to client.EventInterface
This is required so that kubectl can call client.EventInterface.List() with the appropriate field selector.