Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum supported go version to 1.9.1 #55301

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Bump minimum supported go version to 1.9.1 #55301

merged 1 commit into from
Nov 9, 2017
+1 −1

Conversation

xiangpengzhao
Copy link
Contributor

What this PR does / why we need it:
If #55293 gets merged, we should bump minimum_go_version to 1.9.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
ref: #51375 #55293 (comment)

Special notes for your reviewer:
/cc @cblecker @ixdy @luxas

Release note:

The minimum supported go version bumps to 1.9.1.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 8, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2017
@cblecker
Copy link
Member

cblecker commented Nov 8, 2017

/assign

luxas
luxas approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2017
@luxas
Copy link
Member

luxas commented Nov 8, 2017

/retest

Thanks @xiangpengzhao!

@xiangpengzhao
Copy link
Contributor Author

I think there is sth wrong with CI.
Ref: kubernetes/test-infra#5400

@xiangpengzhao
Copy link
Contributor Author

@luxas do we need an announcement for developers on the changing of minimum go version supporting? If so, can you help make the announcement please? I guess it's sth like the last announcement: https://groups.google.com/forum/#!msg/kubernetes-dev/0XRRz6UhhTM/YODWVnuDBQAJ

@luxas
Copy link
Member

luxas commented Nov 8, 2017

@xiangpengzhao I did so already :) https://groups.google.com/forum/#!topic/kubernetes-dev/INeuA9Flcb8

@xiangpengzhao
Copy link
Contributor Author

Oh, thanks @luxas ! I didn't check the mailing list when I copyed the previous announcement link :)

@cblecker
Copy link
Member

cblecker commented Nov 8, 2017

/approve
/retest

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, luxas, xiangpengzhao

Associated issue: 55293

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55301, 55319, 54018, 55322, 55125). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7e1ef2f into kubernetes:master Nov 9, 2017
@xiangpengzhao xiangpengzhao deleted the bump-min-go branch November 9, 2017 04:30
This was referenced Nov 9, 2017
Merged
Merged
@Random-Liu Random-Liu mentioned this pull request Nov 10, 2017
Closed
@krzyzacy krzyzacy mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@jbeda jbeda

@cblecker cblecker

@luxas luxas

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xiangpengzhao @cblecker @luxas @k8s-github-robot @jbeda @eparis @k8s-ci-robot