-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu-distro: deprecate & merge ubuntu single node work to ubuntu cluster node stuff #5498
Conversation
ping @rjnagal & @bgrant0607 |
Thanks for the update @resouer The steps for setting up kube on ubuntu are too complicated right now. Is there any way we can whittle it down to one setup script that accepts master and minions details and automatically sets up these machines with required components. At the least we should try to put most of the setup in cluster/ubuntu-cluster/configure.sh. |
@rjnagal We'd like to refactor it. But there're two approaches and we hope to reach an agreement firstly: Which one do you suggest? Personally, I prefer Ansible which only requires a jump machine and ssh-key configuration. But pure shell solution will be much simpler although less powerful. |
@resouer Adding ansible dependency just to setup minions might be an overkill. If we can setup clusters directly from cluster/ubuntu/utils.sh, we might even be able to use generic https://get.k8s.io script to set things up. To start simple, we can decide on the information we need from the user and read in the config from an env variable. |
@rjnagal Thanks for your advice. Base on your advice, we can simplify the installations workflow like this:
And in
Currently, we only support 1:N model, we can update this to N:M ASAP when we test it through. What do you feel about this design? I don't know if it is possible that owners accept bare-metal as a provider, but we'd like to make that happen if it make sense. |
@rjnagal Could you please do a design review. please 😄 |
I think this is a much better approach than we have now. Go for it! :) On Sun, Mar 22, 2015 at 6:34 PM, Harry Zhang notifications@github.com
|
ping @rjnagal @resouer Our team has almost finished the refactoring work, but there exists a problem to solve.Because we need to put the kubernetes config file in the /etc/ directory and use ubuntu upstart to manage kubernetes jobs, these operations need sudo privilege.We don't want to abuse the sudo privilege in our deployment script.So we decide just ask user to input sudo password when necessary.Although this is a bad scale plan when the machine number is large. |
This is how locally works. Seems fine for now. Suggestions:
On Wed, Apr 15, 2015 at 7:16 PM, Xingyu Chen notifications@github.com
|
08c5738
to
da654b0
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
da654b0
to
8d6beb4
Compare
@googlebot CLA confirmed. Fixing CI. |
8d6beb4
to
9920a8f
Compare
9920a8f
to
4e915f4
Compare
@googlebot CLA confirmed |
4e915f4
to
17c3bf5
Compare
Change log |
The cla check is complaing |
the cla check is confused because the pull request is from @resouer but the commits are from @WIZARD-CXY I'll update it. |
Since cluster dns is not enabled for now. But according to this issue #6667 .It is recommended to have one.So I will update the scripts and doc to automatically set up the cluster dns. |
dfb4425
to
beebfd0
Compare
sorry @rjnagal I can't both get shippable and travis ci right. When I click |
@WIZARD-CXY you can ignore shippable failure as long as travis is passing. Its a bit flaky, I tried out the new script and the cluster came up in a snap. Thanks for spending the time redoing the logic. It's much simpler to use now. Can you squash your 4 commits into one. |
@@ -107,6 +107,17 @@ if [[ "$KUBERNETES_PROVIDER" == "gke" ]]; then | |||
"--kubeconfig=${HOME}/.config/gcloud/kubernetes/kubeconfig" | |||
"--context=gke_${PROJECT}_${ZONE}_${CLUSTER_NAME}" | |||
) | |||
|
|||
elif [[ "$KUBERNETES_PROVIDER" == "libvirt-coreos" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add libvirt-coreos for ubuntu?
beebfd0
to
9a9e8f0
Compare
@rjnagal , thanks for the review and I fix the bug according to your comment.Besides finish the squash work. I think get.k8s.io is more easy for user to use but lack getting etcd and flannel binary and the version customization.Use our build.sh is just fine.If you really want to use it, I can give it a shot and maybe need some update. |
fa4d845
to
657ee0b
Compare
@rjnagal, ok now , looking forward for the merge |
…etter approach and update the guidance
657ee0b
to
595345c
Compare
LGTM Thanks for your patience, @WIZARD-CXY :) |
Ubuntu-distro: deprecate & merge ubuntu single node work to ubuntu cluster node stuff
This PR is based on suggestions form @rjnagal & @bgrant0607 , we have tried to merge the existing ubuntu bare-metal setup into one part.
The merged doc & scripts can both deal with single node setup and cluster setup, it also support flannel as overlay network.
We also use a remote deploy method to make everything automated.