Allow HPA to get custom metrics #54854
Conversation
k8s-ci-robot
added
release-note-none
|
/unassign @deads2k |
| @@ -162,7 +162,7 @@ func buildControllerRoles() ([]rbac.ClusterRole, []rbac.ClusterRoleBinding) { | |||
| rbac.NewRule("get").Groups(legacyGroup).Resources("services/proxy").Names("https:heapster:", "http:heapster:").RuleOrDie(), | |||
| // allow listing resource metrics and custom metrics | |||
| rbac.NewRule("list").Groups(resMetricsGroup).Resources("pods").RuleOrDie(), | |||
There was a problem hiding this comment.
I think this is not necessary - HPA uses this API since PR #53205 and works fine, i.e. e2e tests are passing. See [HPA] tests here: https://k8s-testgrid.appspot.com/google-gce#gci-gce
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-ci-robot
added
release-note
|
/assign @mwielgus |
|
/lgtm |
|
@liggitt Could you please approve this PR? |
|
already done |
|
@liggitt |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, kawych, liggitt, mwielgus Associated issue requirement bypassed by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
| @@ -162,7 +162,7 @@ func buildControllerRoles() ([]rbac.ClusterRole, []rbac.ClusterRoleBinding) { | |||
| rbac.NewRule("get").Groups(legacyGroup).Resources("services/proxy").Names("https:heapster:", "http:heapster:").RuleOrDie(), | |||
| // allow listing resource metrics and custom metrics | |||
| rbac.NewRule("list").Groups(resMetricsGroup).Resources("pods").RuleOrDie(), | |||
| rbac.NewRule("list").Groups(customMetricsGroup).Resources("*").RuleOrDie(), | |||
| rbac.NewRule("get", "list").Groups(customMetricsGroup).Resources("*").RuleOrDie(), | |||
There was a problem hiding this comment.
FWIW "watch" seems to be missing here - while it was there in the original role (https://github.com/GoogleCloudPlatform/k8s-stackdriver/pull/65/files)
There was a problem hiding this comment.
no objection to the permission, but does the custom metrics server support watch?
There was a problem hiding this comment.
Guess it's a question for @kawych :)
What this PR does / why we need it:
This PR allows HPA to read custom metrics.
Release note: