Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COS: Keep the docker network checkpoint #54805

Merged
merged 1 commit into from
Dec 14, 2017
Merged

COS: Keep the docker network checkpoint #54805

merged 1 commit into from
Dec 14, 2017

Conversation

yujuhong
Copy link
Contributor

This is necessary for enabling the live-restore feature.

What this PR does / why we need it:
This is necessary for enabling the live-restore feature on COS.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

COS: Keep the docker network checkpoint

@yujuhong
COS: Keep the docker network checkpoint
e067817 
This is necessary for enabling the live-restore feature.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2017
@yujuhong yujuhong added this to the v1.8 milestone Oct 30, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2017
@dchen1107
Copy link
Member

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yujuhong

Associated issue requirement bypassed by: dchen1107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2017
@yujuhong yujuhong added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2017
@cblecker
Copy link
Member

@yujuhong With #55260 being merged, is this PR still valid?

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@abgworrall @dchen1107 @yujuhong

Action required: This pull request requires label changes. If the required changes are not made within 0 days, the pull request will be moved out of the v1.8 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@yujuhong yujuhong removed this from the v1.8 milestone Nov 17, 2017
@yujuhong
Copy link
Contributor Author

@yujuhong With #55260 being merged, is this PR still valid?

Not needed for now, but will need it later when bumping the COS image version. Keeping the PR open.

@yujuhong
Copy link
Contributor Author

/cc @yguo0905

@abgworrall
Copy link
Contributor

/test pull-kubernetes-unit

@BenTheElder
Copy link
Member

/retest

2 similar comments
@BenTheElder
Copy link
Member

/retest

@yujuhong
Copy link
Contributor Author

/retest

@yujuhong yujuhong removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52259, 53951, 54385, 54805, 55145). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0c6d76b into kubernetes:master Dec 14, 2017
@yujuhong yujuhong deleted the keep-net-checkpoint branch January 26, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguo0905 yguo0905 Awaiting requested review from yguo0905

Assignees

@dchen1107 dchen1107

@abgworrall abgworrall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yujuhong @dchen1107 @k8s-github-robot @cblecker @abgworrall @BenTheElder @k8s-ci-robot