Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #54607 #54678

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Automated cherry pick of #54607 #54678

merged 1 commit into from
Nov 13, 2017

Conversation

andyzhangx
Copy link
Member

Cherry pick of #54607 on release-1.7.

#54607: fix azure pv crash due to readOnly nil

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 27, 2017
@rootfs
Copy link
Contributor

rootfs commented Oct 27, 2017

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, rootfs

Associated issue: 54607

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2017
@brendandburns
Copy link
Contributor

/retest

@brendandburns
Copy link
Contributor

@jdumars can you get the 1.7 release owner to approve this pick?

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@brendandburns
Copy link
Contributor

/retest

@jdumars
Copy link
Member

jdumars commented Nov 10, 2017

@brendandburns working on getting CP traction on this.

@jdumars
Copy link
Member

jdumars commented Nov 10, 2017

/test pull-kubernetes-e2e-gce

2 similar comments
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@jdumars jdumars requested a review from wojtek-t November 12, 2017 17:16
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 13, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Nov 13, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 46cc0ee into kubernetes:release-1.7 Nov 13, 2017
@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#54607-upstream-release-1.7 branch November 20, 2017 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@brendandburns brendandburns

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@andyzhangx @rootfs @k8s-github-robot @brendandburns @jdumars @fejta-bot @wojtek-t @k8s-ci-robot