Make get-password robust against invalid kubeconfig entries #5454
+30
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # is missing. | ||
| # Note: we save dot ('.') to $root because the 'with' action overrides it. | ||
| # See http://golang.org/pkg/text/template/. | ||
| local username='''{{$root := .}}{{with index $root "current-context"}}{{with index $root "contexts" .}}{{with index . "user"}}{{with index $root "users" .}}{{index . "username"}}{{end}}{{end}}{{end}}{{end}}''' |
There was a problem hiding this comment.
Three single quotes ''' does nothing, it's an empty string '' followed by a normal '. Did you need something different here?
There was a problem hiding this comment.
I forgot I added those; removed now. Was trying to do multiline, but that adds unwanted linebreaks in the output.
|
One small nitpick, otherwise looks good. |
|
Looks good, merging. |
filbranden
added a commit
that referenced
this pull request
Mar 13, 2015
Make get-password robust against invalid kubeconfig entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly close #5423, by making
get-passworddo the right thing even if kubeconfig is borked.cc @satnam6502