Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubelet to the master via standard mechanisms. #5453

Merged
merged 1 commit into from
Mar 13, 2015

Conversation

brendandburns
Copy link
Contributor

No description provided.

@vmarmol
Copy link
Contributor

vmarmol commented Mar 13, 2015

LGTM

@vmarmol vmarmol added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2015
vmarmol added a commit that referenced this pull request Mar 13, 2015
Add kubelet to the master via standard mechanisms.
@vmarmol vmarmol merged commit 015bd86 into kubernetes:master Mar 13, 2015
@antoineco
Copy link
Contributor

Sorry if I missed some bits of information, but why do we need a kubelet running on the master?

@vmarmol
Copy link
Contributor

vmarmol commented Apr 28, 2015

@antoineco we run the Kubelet on the master today. The master components run as pods as well.

@antoineco
Copy link
Contributor

Thanks @vmarmol for the quick answer. So this commit (and the ones which followed for other cloud providers) are just meant to prepare the field for running k8s components inside pods in the near future right?

In the current setup the master's kubelet logs are flooded with warning because the master itself is not registered as a node, can it already be handled in some way? (apart from registering the master and making it unschedulable :) )

@vmarmol
Copy link
Contributor

vmarmol commented Apr 28, 2015

Yes, although this change in particular was to make explicit something that we relied on but didn't verify.

Handling the master (by doing exactly what you describe) is being worked on right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants