Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8petstore #5447

Merged
merged 3 commits into from
Mar 17, 2015
Merged

K8petstore #5447

merged 3 commits into from
Mar 17, 2015

Conversation

jayunit100
Copy link
Member

Here it is ! I've finished automating and testing this at 20 and 40 nodes, and added a throughput indicator.

You can see some interesting behaviour happens at times, i.e. flatlining, haven't determined quite exactly why yet, could be a minor glitch in the generator , but since its stochastic, i think its related to stability of containers in certain scenarios.

Ive ran this on up to 40 nodes to generate up to around 500,000 transactions in total.

Would love to scale it further.

All docker code is contained here, including the redis containers themselves so things like /etc/redis conf files can be customized, and also, so that we pegs a specific version to avoid goredis api compatibility syncing issues... w/ excpetion of the bigpetstore data generator, which is already curated in apache bigtop (documentation is in the README for that as well).

To run ? Just run k8petstore.sh :)

@satnam6502
Copy link
Contributor

@jayunit100 please can you suggest a reviewer(s)?

@jayunit100
Copy link
Member Author

Hi satnam. Possbly @brendanburns , and yourself @satnam6502 might be able to review this . It should be very easy to test (just run k8petstore.sh and modify the variables at the top, which are self explanatory, as you see fit)

@jayunit100
Copy link
Member Author

(fyi, the official issue tracker is #5260 )

@satnam6502
Copy link
Contributor

Thanks for the suggestions. I'm on call today so I've asked Brendan to help out.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!


## Architecture of this SOA

A diagram of the overall architecture of this application can be seen in arch.dot (you can paste the contents in any graphviz viewer, including online ones such as http://sandbox.kidstrythisathome.com/erdos/.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkify arch.dot ?

@brendandburns
Copy link
Contributor

Cool, some minor comments on the docs, but generally LGTM.

Thanks for doing this!
--brendan

@jayunit100
Copy link
Member Author

okay updated @brendanburns !

@brendandburns
Copy link
Contributor

Sorry, one more thing, can you run gofmt on:

examples/k8petstore/web-server/src/main/PetStoreBook.go

Thanks!
--brendan

@jayunit100
Copy link
Member Author

okay, done. thats a neat tool. didn't know about it

@brendandburns
Copy link
Contributor

Ugh, travis is trying to build your example code:

https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/54292082

We should either include the right libraries in our Gopath, or block travis from building this somehow.

@jayunit100
Copy link
Member Author

hiya, okay, i;ll look into adding the libraries. Im not sure where to add them so if its non obvious just ping in this thread :)... will update when im done.
UPDATE
okay, I think I see how it works, updating.... GoDeps.json,

@jayunit100
Copy link
Member Author

okay, pushed an to GoDeps ........... we will see if it works. thanks for noticing that !~

@jayunit100
Copy link
Member Author

Well, looks like the build still fails.
Locally I get a funny error building kube ... so I can't really reproduce what travice is doing.
I guess one option is to rename src to _src (like you did in a the other guestbook-go examples/ app) .... but that is only a temporary fix.

@jayunit100
Copy link
Member Author

Well, I got the build working locally:

[jay@rhbd kubernetes]$  go build -v ./... 2>&1 | grep examples
_/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/examples
_/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/examples/liveness/image
_/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/examples/k8petstore/web-server/src/main
[jay@rhbd kubernetes]$ pwd
/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes

I will see if i can follow the directions in the developer docs to build it cleanly. maybe its just working b.c of the local deps which are on my machine, (i.e. possibly i didn't add them correctly into the Godeps json file)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@jayunit100
Copy link
Member Author

@brendandburns okay, i did the temporary disablement of the src dir by moving to _src.

As a follow on , lets work on #5465, as part of which we can get rid of needing to do stuff like that, and bring examples/ into the build

@jayunit100
Copy link
Member Author

(bump) tl;dr this is now passing and ready to merge - i shaded the src package to _src, and updated the dependencies. maybe in a future build, it will pass once travis integrates examples/ src properly.

@smarterclayton
Copy link
Contributor

Squash before merge (once final sign offs are given) please.

@jayunit100
Copy link
Member Author

Squashed into 2 commits (original patch in the first ; cleanup in the second).

@brendandburns
Copy link
Contributor

LGTM, will merge on green.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2015
@j3ffml
Copy link
Contributor

j3ffml commented Mar 17, 2015

lgtm, but needs rebase and squash.

Cleanup k8petstore to use Godeps dependencies, add to hack/build-go.sh
Remove trailing spaces, README
@jayunit100
Copy link
Member Author

okay , rebased and squashed into 3 commits (one containing the fixes which jeff pushed, one containing the cleanups which i made after the original patch, and one with the original code dump). thanks for your help Jeff and Brendan !

brendandburns added a commit that referenced this pull request Mar 17, 2015
@brendandburns brendandburns merged commit 60b2b5d into kubernetes:master Mar 17, 2015
@brendandburns
Copy link
Contributor

merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants