-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8petstore #5447
K8petstore #5447
Conversation
@jayunit100 please can you suggest a reviewer(s)? |
Hi satnam. Possbly @brendanburns , and yourself @satnam6502 might be able to review this . It should be very easy to test (just run |
(fyi, the official issue tracker is #5260 ) |
Thanks for the suggestions. I'm on call today so I've asked Brendan to help out. |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
CLAs look good, thanks! |
|
||
## Architecture of this SOA | ||
|
||
A diagram of the overall architecture of this application can be seen in arch.dot (you can paste the contents in any graphviz viewer, including online ones such as http://sandbox.kidstrythisathome.com/erdos/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linkify arch.dot ?
Cool, some minor comments on the docs, but generally LGTM. Thanks for doing this! |
okay updated @brendanburns ! |
Sorry, one more thing, can you run gofmt on: examples/k8petstore/web-server/src/main/PetStoreBook.go Thanks! |
okay, done. thats a neat tool. didn't know about it |
Ugh, travis is trying to build your example code: https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/54292082 We should either include the right libraries in our Gopath, or block travis from building this somehow. |
hiya, okay, i;ll look into adding the libraries. Im not sure where to add them so if its non obvious just ping in this thread :)... will update when im done. |
okay, pushed an to GoDeps ........... we will see if it works. thanks for noticing that !~ |
Well, looks like the build still fails. |
Well, I got the build working locally:
I will see if i can follow the directions in the developer docs to build it cleanly. maybe its just working b.c of the local deps which are on my machine, (i.e. possibly i didn't add them correctly into the Godeps json file) |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
@brendandburns okay, i did the temporary disablement of the As a follow on , lets work on #5465, as part of which we can get rid of needing to do stuff like that, and bring |
(bump) tl;dr this is now passing and ready to merge - i shaded the src package to |
Squash before merge (once final sign offs are given) please. |
Squashed into 2 commits (original patch in the first ; cleanup in the second). |
LGTM, will merge on green. |
lgtm, but needs rebase and squash. |
Cleanup k8petstore to use Godeps dependencies, add to hack/build-go.sh Remove trailing spaces, README
okay , rebased and squashed into 3 commits (one containing the fixes which jeff pushed, one containing the cleanups which i made after the original patch, and one with the original code dump). thanks for your help Jeff and Brendan ! |
merged! |
Here it is ! I've finished automating and testing this at 20 and 40 nodes, and added a throughput indicator.
You can see some interesting behaviour happens at times, i.e. flatlining, haven't determined quite exactly why yet, could be a minor glitch in the generator , but since its stochastic, i think its related to stability of containers in certain scenarios.
Ive ran this on up to 40 nodes to generate up to around 500,000 transactions in total.
Would love to scale it further.
All docker code is contained here, including the redis containers themselves so things like /etc/redis conf files can be customized, and also, so that we pegs a specific version to avoid goredis api compatibility syncing issues... w/ excpetion of the bigpetstore data generator, which is already curated in apache bigtop (documentation is in the README for that as well).
To run ? Just run
k8petstore.sh
:)