Add an rc strategy, start delta validating updates #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if strings.Index(err.Error(), "Controller.Namespace does not match the provided context") == -1 { | ||
| t.Errorf("Expected 'Controller.Namespace does not match the provided context' error, got '%v'", err.Error()) | ||
| } else if !errors.IsBadRequest(err) { | ||
| t.Errorf("Expected a Bad Request error, got %v", err) |
There was a problem hiding this comment.
Can we still verify that the error message contains the word "namespace"? Generic "bad request" errors are a really bad user experience...
|
LGTM, just a few minor questions/nits |
bprashanth
force-pushed
the
rc_validation
branch
from
bc90377
to
6193608
Compare
|
LGTM |
lavalamp
added a commit
that referenced
this pull request
Mar 13, 2015
Add an rc strategy, start delta validating updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teaches replication controller to validate updates by giving the controller's
RESTStorageaRESTUpdateStrategy. Validation now happens viaBeforeUpdate, which compares the existing object with the update before applying it. This is the first step to moving the replication controller to using generic etcd, it also fixes #4973.