Ported guestbook.sh e2e test to ginkgo #5439
Conversation
|
Please note that the test may cause some problems due to #5431 |
| Describe("guestbook", func() { | ||
| var ( | ||
| guestbookPath = filepath.Join(testContext.repoRoot, "examples/guestbook") | ||
| frontendSelector = "name=frontend" |
There was a problem hiding this comment.
The vars here that are just strings should be defined in a const block instead of a var block:
const (
frontendSelector = "name=frontend"
redisMasterSelector = "name=redis-master"
redisSlave = "name=redis-slave"
)
var guestbookPath = filepath.Join(...)
|
Thanks for comments. PTAL |
|
LGTM. Please squash before I merge (on Monday). I take it that I should merge #5452 first though. |
roberthbailey
added
the
lgtm
|
Squashed. Thanks for review! |
|
Also should be submitted after #5504 |
| redisMasterSelector = "name=redis-master" | ||
| redisSlaveSelector = "name=redis-slave" | ||
| kubectlProxyPort = 8011 | ||
| guestbookResponseTimeout = 2 * time.Minute |
There was a problem hiding this comment.
I would bump this to 10 minutes. This timeout includes waiting for multiple pods/services/replication controllers to be created. The default pod creation timeout we use is 5 minutes.
There was a problem hiding this comment.
To add a bit of explanation, the longer timeout helps reduce flakiness from slow, serialized docker image pulls (see #4566).
|
Travis (finally) passed. Merging. |
Ported guestbook.sh e2e test to ginkgo
This fixed #5045