Option to enable profiling on the master daemon processes. #5438
Conversation
--profiling=true , default is false
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
@satnam6502 | @davidopp any chance of review 2day? |
|
LGTM, I would even say to turn it on by default :) It doesn't have a runtime penalty, but it may be used to DOS the service so off by default may be safer. |
Option to enable profiling on the master daemon processes.
Following https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/profiling.md
I've added options to the master daemons to enable profiling, default is off/false.