Use UTC when marshalling times and Local when unmarshalling #5416
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
satnam6502
added
the
lgtm
|
Second attempt at kicking Travis. |
|
Third attempt at kicking Travis. |
|
@smarterclayton why does this keep failing in Travis? |
|
Good question, I'll look. Might be nanosecond precision or something specific about the TZ travis is in. Dates are fun... ----- Original Message -----
|
smarterclayton
force-pushed
the
use_utc_serialized_and_local_otherwise
branch
from
833ab0f to
dc1580a
Compare
Marshal to UTC and read into Local, which means clients automatically show local time and stored values are always consistent.
smarterclayton
force-pushed
the
use_utc_serialized_and_local_otherwise
branch
from
dc1580a to
d516a86
Compare
|
Ok, I fixed the travis problem. Unmarshal does not return a deterministic "Location" pointer. Changed the tests to verify the timezone and offset were identical, then checked UnixNano. Should be ready for rereview and tests pass. |
|
Flake, rerunning the one travis. |
|
Still red. |
|
Failure is unrelated - another issue open for it already. |
|
Travis is green |
|
Sorry, just past merge hours. Oncall: please merge in the morning. |
…ocal_otherwise Use UTC when marshalling times and Local when unmarshalling
Marshal to UTC and read into Local, which means clients automatically
show local time and stored values are always consistent.
Closes remaining issue from #5183