fix proxy_test.go file to avoid ChooseHostInterface #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked this out and successfully ran unit tests on OS X. |
|
@brendandburns : is this an LGTM? |
brendandburns
added a commit
that referenced
this pull request
Mar 13, 2015
fix proxy_test.go file to avoid ChooseHostInterface
| return CreateProxier(loadBalancer, listenIP, iptables, hostIP) | ||
| } | ||
|
|
||
| func CreateProxier(loadBalancer LoadBalancer, listenIP net.IP, iptables iptables.Interface, hostIP net.IP) *Proxier { |
There was a problem hiding this comment.
This should not be a public symbol - createProxier() or newProxierInternal() please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brendanburns @markturansky
kindly review
should fix the mac tests failing