Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-gen: register standard flags #53999

Merged
merged 1 commit into from
Oct 23, 2017
Merged

client-gen: register standard flags #53999

merged 1 commit into from
Oct 23, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Oct 16, 2017 •
edited
Loading

Fixes #53998.

The first flag.Parse refuses the glog and gengo flags because the go-flags are only added to the flagset when gengo's execute is called. On master this was fixed via #53202. Here we apply a minimal patch only.

Allow standard flags in client-gen.

@sttts sttts added cherrypick-candidate kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 16, 2017
@sttts sttts added this to the v1.8 milestone Oct 16, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 16, 2017
@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 16, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 16, 2017
@sttts sttts changed the title client-gen: register standard flags WIP: client-gen: register standard flags Oct 16, 2017
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2017
@sttts sttts closed this Oct 16, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Oct 18, 2017

@sttts why was this closed?

@sttts
Copy link
Contributor Author

sttts commented Oct 19, 2017

@mfojtik actually half of #53998 was false alarm (gengo flags are registered). That was the part that interested me. But glog flags are still an issue. Ptal and test if you have time.

@sttts sttts reopened this Oct 19, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Oct 19, 2017

I think this is still worth for the golog flags :-) I'm going to make some changes to clientgen today, so I will test this PR. The code looks good to me.

@sttts sttts changed the title WIP: client-gen: register standard flags client-gen: register standard flags Oct 19, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2017
@sttts
Copy link
Contributor Author

sttts commented Oct 19, 2017

@mfojtik note that this is a quickfix for 1.8. In master we only call Parse() once. So I believe we don't have the problem there at all. If we do, PR welcome :-)

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate labels Oct 20, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 20, 2017
@sttts
Copy link
Contributor Author

sttts commented Oct 23, 2017

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Oct 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

Associated issue: 53998

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 85ff8bc into kubernetes:release-1.8 Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
6 participants
@sttts @mfojtik @k8s-github-robot @jpbetz @thockin @k8s-ci-robot