kubelet sync pod throws more detailed events #53857
Merged
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
derekwaynecarr
added
the
do-not-merge/work-in-progress
|
marking do-not-merge while i perform some tests to ensure this will not introduce problems, but now that the client side event spam merged, it should be safer to provide more granular events to help users understand and report problems. |
|
/lgtm I don't see how a user could conjure a pod to hit these and create a bunch of spam so that's good. This will be very helpful 👍 |
k8s-ci-robot
added
the
lgtm
derekwaynecarr
force-pushed
the
sync-event
branch
from
90f01a0 to
519e543
Compare
k8s-github-robot
removed
the
lgtm
|
before merging, i need to make sure long tail of events doesnt change from prior measurements, and i would like to verify the errors are not hideous. |
|
testing this out, prefer we keep all events from containerruntime.SyncPod local to that operation. |
derekwaynecarr
force-pushed
the
sync-event
branch
2 times, most recently
from
1126891 to
be45d31
Compare
derekwaynecarr
force-pushed
the
sync-event
branch
from
be45d31 to
5422460
Compare
k8s-ci-robot
added
size/M
|
This reminds me I need to fixup the event table output on kubectl get
events to match the changes made for describe.
…On Fri, Oct 13, 2017 at 12:06 AM, k8s-ci-robot ***@***.***> wrote:
@derekwaynecarr <https://github.com/derekwaynecarr>: The following test
*failed*, say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-unit 1126891
<1126891>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/53857/pull-kubernetes-unit/58107/> /test
pull-kubernetes-unit
Full PR test history <https://k8s-gubernator.appspot.com/pr/53857>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/derekwaynecarr>.
Please help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#53857 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p5VUZzKzKiQ_DnwU00KgRqSrc3JNks5sruG9gaJpZM4P33nk>
.
|
derekwaynecarr
removed
the
do-not-merge/work-in-progress
|
i think this is good to go |
|
/lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
|
added the issue to make bot happy /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, eparis, joelsmith, sjenning Associated issue: 53900 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 51840, 53542, 53857, 53831, 53702). If you want to cherry-pick this change to another branch, please follow the instructions here. |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Oct 17, 2017
Automatic merge from submit-queue (batch tested with PRs 16889, 16865). UPSTREAM: 53857: kubelet sync pod throws more detailed events Also includes the following upstream dependant PRs: UPSTREAM: 50350: Wait for container cleanup before deletion UPSTREAM: 48970: Recreate pod sandbox when the sandbox does not have an IP address. UPSTREAM: 48589: When faild create pod sandbox record event. UPSTREAM: 48584: Move event type UPSTREAM: 47599: Rerun init containers when the pod needs to be restarted xrefs: kubernetes/kubernetes#53857 kubernetes/kubernetes#50350 kubernetes/kubernetes#48970 kubernetes/kubernetes#48589 kubernetes/kubernetes#48584 kubernetes/kubernetes#47599
|
It is very valuable for troubleshooting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If there are errors in the kubelet sync pod iteration, it is difficult to determine the problem.
This provides more specific events for errors that occur in the syncPod iteration to help perform problem isolation.
Fixes #53900
Special notes for your reviewer:
It is safer to dispatch more specific events now that we have an event budget per object enforced via #47367
Release note: