Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix controller manager crash issue on a manually created azure k8s cluster #53694

Merged
merged 1 commit into from
Oct 16, 2017
Merged

fix controller manager crash issue on a manually created azure k8s cluster #53694

merged 1 commit into from
Oct 16, 2017

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 11, 2017 •
edited by enisoc
Loading

What this PR does / why we need it:
fix controller manager crash issue on a manually created k8s cluster, it's due to availability set nil issue in azure loadbalancer

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
In the testing of a manually created k8s cluster, I found controller manager on master would crash in current scenario:

  1. Use acs-engine to set up k8s 1.7.7 cluster (it's with an availability set)
  2. Manually add a node to the k8s cluster (without an availibity set in this VM)
  3. Set up a service and schedule the pod onto this newly added node
  4. controller manager would crash on master because although this k8s cluster has an availability set, the newly added node's machine.AvailabilitySet is nil which would cause controller manager crash

Special notes for your reviewer:
@brendanburns @karataliu @JiangtianLi

Release note:

Azure cloudprovider: Fix controller manager crash issue on a manually created k8s cluster.

/sig azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/azure size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2017
@jdumars
Copy link
Member

jdumars commented Oct 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2017
@andyzhangx
Copy link
Member Author

Hi @jingxu97 , could you take a look, thx

@andyzhangx
Copy link
Member Author

@jdumars could you approve by /approve no-issue, thx

@jdumars
Copy link
Member

jdumars commented Oct 16, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jdumars

Associated issue requirement bypassed by: jdumars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 16, 2017 •
edited
Loading

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 6920141 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53694, 53919). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6118a4b into kubernetes:master Oct 16, 2017
@andyzhangx andyzhangx changed the title fix controller manager crash issue on a manually created k8s cluster fix controller manager crash issue on a manually created azure k8s cluster Oct 17, 2017
This was referenced Oct 17, 2017
Merged
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 19, 2017
Merge pull request #54051 from andyzhangx/automated-cherry-pick-of-#5…
13adc4a 
…3694-upstream-release-1.6

Automatic merge from submit-queue.

Automated cherry pick of #53694

Cherry pick of #53694 on release-1.6.

#53694: fix avset nil issue in azure loadbalancer
**Release note**:

```
fix controller manager crash issue on a manually created azure k8s cluster
```
k8s-github-robot pushed a commit that referenced this pull request Nov 6, 2017
Merge pull request #54050 from andyzhangx/automated-cherry-pick-of-#5…
55e3a62 
…3694-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53694

Cherry pick of #53694 on release-1.8.

#53694: fix avset nil issue in azure loadbalancer
**Release note**:

```
Fix controller manager crash issue on a manually created azure k8s cluster
```
k8s-github-robot pushed a commit that referenced this pull request Nov 17, 2017
Merge pull request #54048 from andyzhangx/automated-cherry-pick-of-#5…
89bf442 
…3694-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #53694

Cherry pick of #53694 on release-1.7.

#53694: fix avset nil issue in azure loadbalancer

**Release note**:

```
fix controller manager crash issue on a manually created azure k8s cluster
```
@andyzhangx andyzhangx deleted the azure-avset-nil-fix branch May 8, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@jdumars jdumars

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andyzhangx @jdumars @k8s-github-robot @k8s-ci-robot @liggitt @jingxu97