Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to prevent downward api change break on older versions #53673

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Fix to prevent downward api change break on older versions #53673

merged 1 commit into from
Oct 11, 2017
+5 −0

Conversation

timothysc
Copy link
Member

Signed-off-by: Timothy St. Clair timothysc@gmail.com

What this PR does / why we need it:
Prevents "should provide pod and host IP as an env var [Conformance]" from running on older versions whose api does not have that field and will break on those clusters.

This is not a upstream tested configuration, but downstream folks do this regularly.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
N/A

Special notes for your reviewer:
N/A

Release note:

Prevent downward api-change from breaking on older version

/cc @kubernetes/sig-testing-bugs @jpbetz @marun

@timothysc timothysc added cherrypick-candidate release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 10, 2017
@timothysc timothysc added this to the v1.8 milestone Oct 10, 2017
@timothysc timothysc requested review from jpbetz and ixdy October 10, 2017 20:24
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2017
@timothysc
Fix to prevent downward api change break on older versions
db7cb5f 
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
@timothysc timothysc force-pushed the downward_hostip_e2e branch from 856ea77 to db7cb5f Compare October 10, 2017 20:32
@timothysc timothysc mentioned this pull request Oct 10, 2017
Merged
@kubernetes kubernetes deleted a comment from k8s-ci-robot Oct 10, 2017
@ixdy
Copy link
Member

ixdy commented Oct 10, 2017

/approve

@ixdy
Copy link
Member

ixdy commented Oct 10, 2017

side note: should we require all [Conformance] tests to have a version guard?

@timothysc
Copy link
Member Author

timothysc commented Oct 10, 2017 •
edited
Loading

@ixdy anything that adds new fields or apis, then yes.

@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2017
@timothysc
Copy link
Member Author

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce-etcd3

@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 10, 2017
@jpbetz
Copy link
Contributor

jpbetz commented Oct 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2017
@jpbetz
Copy link
Contributor

jpbetz commented Oct 10, 2017

/approve no-issue

@jpbetz
Copy link
Contributor

jpbetz commented Oct 11, 2017

@timothysc The merge bot blocked waiting on an associated issue. I don't have the permissions to approve. Would you either add an issue or get the needed /approve no-issue?

@timothysc
Copy link
Member Author

@jpbetz I added the label, it's currently waiting on pull-kubernetes-e2e-kubeadm-gce

@timothysc
Copy link
Member Author

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ixdy, jpbetz, timothysc

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53678, 53677, 53682, 53673). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3ac4762 into kubernetes:master Oct 11, 2017
@jpbetz jpbetz modified the milestone: v1.8 Oct 11, 2017
@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Oct 11, 2017
@jpbetz jpbetz mentioned this pull request Oct 11, 2017
Merged
@jpbetz jpbetz removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 11, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 11, 2017
Merge pull request #53699 from jpbetz/automated-cherry-pick-of-#53551-#…
6c5503e 
…53673-origin-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53551 #53673

Cherry pick of #53551 #53673 on release-1.8.

#53551: Add client and server versions to the e2e.test output.
#53673: Fix to prevent downward api change break on older versions

**Release note**:
```
Prevent downward api-change from breaking on older version
```
@jpbetz jpbetz removed this from the v1.8 milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@marun marun

@jpbetz jpbetz

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timothysc @ixdy @jpbetz @k8s-github-robot @marun @k8s-ci-robot