Make scheduler to watch PodSpec.Host instead Status.Host #5363
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run e2e tests, however 3 of them are currently failing in head - so please do NOT merge this PR before they are fixed and I will rerun e2e tests. |
|
Please rebase and try e2e again. |
|
Running now - will paste results when finished. |
|
e2e tests passed: Ran 25 of 26 Specs in 1402.894 seconds |
|
It seems that PR also addresses watching Spec.Host in kubelet, as getHostFieldLabel method is used by apiserver watch. |
|
LGTM. |
bgrant0607
added a commit
that referenced
this pull request
Mar 12, 2015
Make scheduler to watch PodSpec.Host instead Status.Host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #5207.
cc @jszczepkowski @bgrant0607