Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Spec.Host to Status.Host on pod creation #5355

Merged
merged 1 commit into from
Mar 12, 2015

Conversation

yujuhong
Copy link
Contributor

No description provided.

@yujuhong
Copy link
Contributor Author

This is related to #5256 (wrong reference, corrected).

Copying the host from spec to status probably doesn't belong in ResetBeforeCreate(), but since we'd eventually remove status.host, it seems like an okay temporary fix to unblock the use of Spec.Host.

@bgrant0607

@bgrant0607
Copy link
Member

This is just for the case that the pod is created with Spec.Host set rather than being scheduled later? Is that the only case that doesn't work currently?

Probably the defaulting code would be more appropriate, though I realize this was easier. I don't have a strong preference, since I'm hoping this will all be gone soon.

@bgrant0607 bgrant0607 self-assigned this Mar 12, 2015
@yujuhong
Copy link
Contributor Author

Yes, this PR applies only to the pods with Spec.Host already set by the client on creation. So far, this is the only case that I've discovered.

Since this is going to be removed soon, I think it's fine. I can test again once the "posting pod status from kubelet" PR is merged, and remove this if it's no longer an issue.

Thanks!

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2015
@wojtek-t
Copy link
Member

I think it's not clear from the above:
#5256 seems to break 3 e2e tests - this PR is fixing 2 of them (the PD-related ones)

cc @jszczepkowski

@bgrant0607
Copy link
Member

We probably should just revert #5256, then.

@wojtek-t
Copy link
Member

This was also my first thought, but I changed my mind, because two fix all those three tests we just need to merge 2 PR that already exist:
#5355 (this one)
#5364
Both PRs are one-liners, thus I think it might make sense to merge them instead of reverting this one.

What do you think about it?

@bgrant0607
Copy link
Member

Ok, sure. Let's merge those 2.

bgrant0607 added a commit that referenced this pull request Mar 12, 2015
Copy Spec.Host to Status.Host on pod creation
@bgrant0607 bgrant0607 merged commit 3cbe9aa into kubernetes:master Mar 12, 2015
@wojtek-t
Copy link
Member

Thanks Brian!

@yujuhong yujuhong deleted the fixspechost branch March 23, 2015 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants