-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Spec.Host to Status.Host on pod creation #5355
Conversation
This is related to #5256 (wrong reference, corrected). Copying the host from spec to status probably doesn't belong in |
This is just for the case that the pod is created with Spec.Host set rather than being scheduled later? Is that the only case that doesn't work currently? Probably the defaulting code would be more appropriate, though I realize this was easier. I don't have a strong preference, since I'm hoping this will all be gone soon. |
Yes, this PR applies only to the pods with Spec.Host already set by the client on creation. So far, this is the only case that I've discovered. Since this is going to be removed soon, I think it's fine. I can test again once the "posting pod status from kubelet" PR is merged, and remove this if it's no longer an issue. Thanks! |
I think it's not clear from the above: |
We probably should just revert #5256, then. |
Ok, sure. Let's merge those 2. |
Copy Spec.Host to Status.Host on pod creation
Thanks Brian! |
No description provided.