Etcd watcher #535
Merged
Etcd watcher #535
+338
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,3 +307,91 @@ func TestPolling(t *testing.T) { | |||
| f() | |||
| } | |||
| } | |||
|
|
|||
| var watchTestTable = []struct { | |||
There was a problem hiding this comment.
Any reason this isn't part of TestWatch? Feels like this is the real test case (which should be prominent in the TestWatch method), and the rest of the code is the boilerplate necessary to make the test.
|
@smarterclayton, both comments addressed in #505. |
|
I think my implementation here isn't quite right-- I fixed it in #549. Can just combine with that (and drop this PR) if you want. |
|
@smarterclayton: Comment addressed (ew -> w). |
|
LGTM with answers to the two questions |
|
Ok, LGTM and this is a net new interface so folks on vacation can register their discontent in subsequent pulls |
|
Feel free to merge this any time... :) |
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Added a basic api interface for events
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
* Support provisioning baremetal cluster with ansible
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
* Support provisioning baremetal cluster with ansible
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
Follow sig list to kubernetes/community
jsafrane
pushed a commit
to jsafrane/kubernetes
that referenced
this pull request
Mar 1, 2021
…rry-pick-531-to-release-4.6 [release-4.6] Bug 1919069: UPSTREAM: 98103: kubelet: Delete static pod gracefully and fix mirrorPodTerminationMap leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #505, this implements etcd's watch in a form that I can hook up to the apiserver.