Increase backoffLimit for job that we expect to fail several times #53380
Conversation
k8s-ci-robot
added
release-note-none
k8s-github-robot
added
the
approved
|
/retest |
| @@ -77,7 +77,7 @@ var _ = SIGDescribe("Job", func() { | |||
| // Worst case analysis: 15 failures, each taking 1 minute to | |||
| // run due to some slowness, 1 in 2^15 chance of happening, | |||
| // causing test flake. Should be very rare. | |||
There was a problem hiding this comment.
Should this worst case analysis be updated?
There was a problem hiding this comment.
No, that part stays as it was.
There was a problem hiding this comment.
Is this for test execution time or test flakiness? The "should be very rare" statement does not hold true given the test flakes we saw.
There was a problem hiding this comment.
"should be very rare" is still true, given that the failure limit is high. Otherwise we'll hit it too soon and that's the reason the flakiness rate recently. It started only after we've added that limit with default 6.
|
/lgtm |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erictune, soltysh Associated issue: 35507 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Review the full test history for this PR. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Since the introduction of
backoffLimitfor a job that single test failed majority of times on:BackoffLimitExceeded: Job has reach the specified backoff limit.I'm bumping this to 999, so that it has enough room to fail several times.
Which issue this PR fixes:
Fixes #35507.
Special notes for your reviewer:
Release note: