Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /swagger.json and /swagger-2.0.0.pb-v1 to discovery role #53359

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Add /swagger.json and /swagger-2.0.0.pb-v1 to discovery role #53359

merged 1 commit into from
Oct 3, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 3, 2017 •
edited
Loading

Allow access to openapi docs
Fixes #53349

@k8s-ci-robot
Copy link
Contributor

@liggitt: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2017
@liggitt liggitt mentioned this pull request Oct 3, 2017
Closed
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 3, 2017
@enj
Copy link
Member

enj commented Oct 3, 2017

Meh, per discussion on the linked issue, I guess this is a necessary hack.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

Associated issue: 53349

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Oct 3, 2017

/retest

@liggitt liggitt added this to the v1.9 milestone Oct 3, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50749, 52869, 53359). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8eb37ae into kubernetes:master Oct 3, 2017
@liggitt liggitt deleted the swagger.json branch October 4, 2017 17:48
@roffe roffe mentioned this pull request Oct 12, 2017
Closed
@liggitt liggitt mentioned this pull request Oct 12, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 14, 2017
Merge pull request #53802 from liggitt/automated-cherry-pick-of-#5335…
47114c8 
…9-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53359

Cherry pick of #53359 on release-1.8.

#53359: Add /swagger.json and /swagger-2.0.0.pb-v1 to discovery role

```release-note
Fixes forbidden errors accessing openapi discovery documents
```
@liggitt liggitt mentioned this pull request Nov 23, 2017
Closed
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate labels Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enj enj

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-ci-robot @enj @k8s-github-robot @deads2k @wojtek-t