Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moves admission.v1alpha1.NewAdmissionReview method to webhook plugin #53343

Merged
merged 1 commit into from
Oct 5, 2017
Merged

moves admission.v1alpha1.NewAdmissionReview method to webhook plugin #53343

merged 1 commit into from
Oct 5, 2017
+31 −37

Conversation

p0lyn0mial
Copy link
Contributor

What this PR does / why we need it:
this is necessary, because the webhook plugin will be moved down to apiserver.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2017
@p0lyn0mial
Copy link
Contributor Author

/assign @deads2k

@p0lyn0mial p0lyn0mial changed the title moves admission.v1alpha1.NewAdmissionReview to webhook plugin moves admission.v1alpha1.NewAdmissionReview method to webhook plugin Oct 2, 2017
@p0lyn0mial
Copy link
Contributor Author

/retest

@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2017

Need to get green, but this

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2017
@p0lyn0mial
moves admission.v1alpha1.NewAdmissionReview to webhook plugin
1871712 
this is necessary, because the webhook plugin will be moved down to apiserver.
@p0lyn0mial p0lyn0mial force-pushed the move_newAdmissionReview_method_to_webhook branch from d6587a4 to 1871712 Compare October 4, 2017 17:51
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2017
@p0lyn0mial
Copy link
Contributor Author

/retest

@p0lyn0mial
Copy link
Contributor Author

@deads2k just the plugin/pkg/admission/webhook/BUILD update, please tag the pull.

@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2017

moving code to point of use.

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2017
@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial
We suggest the following additional approvers: derekwaynecarr, smarterclayton

Assign the PR to them by writing /assign @derekwaynecarr @smarterclayton in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c1703a4 into kubernetes:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/admission-control cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@p0lyn0mial @deads2k @k8s-github-robot @erictune @k8s-ci-robot