Remove swagger 1.2 validation #53232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
release-note
|
/retest |
apelisse
force-pushed
the
remove-swagger-validation
branch
from
8188bb0 to
80fd010
Compare
|
@pwittrock Can you please have a quick look at that? |
|
This change is |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
/sig cli |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apelisse, pwittrock No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 53228, 53232, 53353). If you want to cherry-pick this change to another branch, please follow the instructions here. |
gregory-lyons
pushed a commit
to box/kube-applier
that referenced
this pull request
Jan 26, 2019
This flag was removed in Kubernetes 1.9 and I don't think we need it anymore: kubernetes/kubernetes#53232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes dependency on swagger 1.2 for validation. Always uses openapi.
cc @mbohlool
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #44589Special notes for your reviewer:
Release note: