Calculate patches for commands using input version #53158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
k8s-github-robot
added
approved
|
cc @kubernetes/sig-cli-pr-reviews @janetkuo |
k8s-ci-robot
added
the
sig/cli
|
/retest |
liggitt
added
release-note
liggitt
force-pushed
the
update-pod-spec-versioned
branch
from
4112b31 to
e3a8b5e
Compare
k8s-ci-robot
added
size/M
done |
k8s-github-robot
removed
the
approved
|
kernel panic flake in pull-kubernetes-e2e-gce-bazel #50695 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, pwittrock Associated issue: 53040 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 53101, 53158, 52165). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 30, 2017
…8-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #53158 Fixes #53040 Cherry pick of #53158 on release-1.8. #53158: Calculate patches for commands using input version ```release-note Fixes an issue with `kubectl set` commands encountering conversion errors for ReplicaSet and DaemonSet objects ```
|
Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53040
the encoder used for encoding these objects while calculating patches does not have sufficient information to select a correct version when the object does not exist in all versions of a target group (like replicasets not existing in apps/v1beta1)
this PR wraps the encoder to first convert to the same version used to read the object (based on the mapping's GroupVersion)
long-term, we should switch UpdatePodSpecForObject to work on versioned objects and v1.PodSpec and avoid conversion altogether