Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run IPVS proxier UTs everywhere - include !linux platfrom #53097

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Run IPVS proxier UTs everywhere - include !linux platfrom #53097

merged 1 commit into from
Oct 6, 2017

Conversation

m1093782566
Copy link
Contributor

@m1093782566 m1093782566 commented Sep 27, 2017 •
edited
Loading

What this PR does / why we need it:

IPVS proxier UTs should run everywhere, including !linux platfrom, which will help a lot when developing in windows platfrom.

Which issue this PR fixes:

fixes #53099

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 27, 2017
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 27, 2017
@k8s-github-robot k8s-github-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2017
@thockin
Copy link
Member

thockin commented Oct 5, 2017

I don't understand - does IPVS work on windows and Mac OS?

@m1093782566
Copy link
Contributor Author

m1093782566 commented Oct 6, 2017 •
edited
Loading

@thockin

IPVS does not work on Windows or MacOS - that's true. However, the pkg/proxy/ipvs/proxier_test.go call FakeIPVS, which is defined in pkg/util/ipvs/testing/fake.go. We can run methods of FakeIPVS everywhere. Thinking of iptables, iptables/proxier_test.go can run everywhere.

I think many people(including me) are developing on Windows or MacOS. Support running UTs in these systems can help developers find some mistakes easily.

@m1093782566
Copy link
Contributor Author

In other words, we mock IPVS in ipvs/proxier_test.go, so it can work on windows or mac os.

@thockin
Copy link
Member

thockin commented Oct 6, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, thockin

Associated issue: 53099

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2017
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52768, 51898, 53510, 53097, 53058). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5c9e36e into kubernetes:master Oct 6, 2017
@m1093782566 m1093782566 deleted the ipvs-test branch October 7, 2017 02:50
@ixdy ixdy mentioned this pull request Jun 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@vishh vishh

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run IPVS proxier UTs everywhere - include !linux platfrom
6 participants
@m1093782566 @thockin @k8s-github-robot @vishh @dcbw @k8s-ci-robot