NamespaceLifecycle admission control plugin #5288
Conversation
| return c.Namespaces().List(labels.Everything()) | ||
| }, | ||
| WatchFunc: func(resourceVersion string) (watch.Interface, error) { | ||
| return c.Namespaces().Watch(labels.Everything(), labels.Everything(), resourceVersion) |
There was a problem hiding this comment.
I believe we have a fields.Everything() now.
There was a problem hiding this comment.
Will update this. My other PR that actually does the delete has the changes to move to fields.Everything()
|
Assigning to @erictune, who I believe is more familiar with admission control plugins. |
bgrant0607
added
the
lgtm
|
LGTM |
derekwaynecarr
force-pushed
the
namespace_lifecycle
branch
from
55ea641
to
8aa807b
Compare
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
@bgrant0607 - made the update to move to fields.Everything() so this should be good if we get green travis |
NamespaceLifecycle admission control plugin
If a Namespace is undergoing graceful termination, prohibit any CREATE actions in that namespace. This admission control plug-in will be enabled once we have a NamespaceController that is actually doing the graceful termination.
See #5195 for design details.