Standalone kubeconfig for gce kube-up (mulligan) #5264
Merged
+150
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweaked the ginkgo tests to pull auth directly from a kubeconfig file instead of the legacy kubernetes_auth file.
| # KUBECONFIG determines the file we write to, but it may not exist yet | ||
| if [[ ! -e "${KUBECONFIG}" ]]; then | ||
| mkdir -p $(dirname "${KUBECONFIG}") | ||
| touch "${KUBECONFIG}" |
There was a problem hiding this comment.
Do you care about the umask here?
There was a problem hiding this comment.
I think 077 is correct. Or do you mean I should explicitly set umask here?
There was a problem hiding this comment.
Yeah, I was more asking if we should be explicit here. I don't think it matters much, though.
There was a problem hiding this comment.
... we're not explicit elsewhere. So. Let's proceed for now.
There was a problem hiding this comment.
It doesn't actually matter. We'll be using kubectl to write to the file in the next line, and kubectl sets permissions explicitly.
zmerlynn
added a commit
that referenced
this pull request
Mar 11, 2015
Standalone kubeconfig for gce kube-up (mulligan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un-revert of #5154. Added check to create empty
.kubeconfigif the provided one doesn't exist. That should make it work on jenkins, which runs e2e from a redirected, empty $HOME.cc @zmerlynn, @satnam6502