Delete target pools and forwarding rules with -q in guestbook.sh #5262
Conversation
| } | ||
|
|
||
| prepare-e2e | ||
|
|
||
| trap "teardown" EXIT | ||
|
|
||
| if gcloud config list compute/region --format text | grep 'compute.region: None'; then |
There was a problem hiding this comment.
I think you need to hack out region instead, see e.g. https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/gce/util.sh#L625.
There was a problem hiding this comment.
Doesn't that just take the ZONE from an env variable and use it to recreate the region, are you recommending a similar approach?
I could use sed/awk or something to parse out 'None' but I figured eitherway I won't know what to search for, and if the format of the string changes both will most likely break. Thoughts?
There was a problem hiding this comment.
Yes, I'm recommending a similar approach given the e2e zone, which is what we have to do in other tests as well (I think there are a few other cases). You actually don't care what the gcloud default is, FWIW - I run my e2es in a different zone (though the same region, I guess), than my default zone.
There was a problem hiding this comment.
Makes sense, updated.
bprashanth
force-pushed
the
e2e_services
branch
from
d4c143b to
7bc472a
Compare
bprashanth
force-pushed
the
e2e_services
branch
from
7bc472a to
1ae44c3
Compare
|
PTAL |
Delete target pools and forwarding rules with -q in guestbook.sh
Without -q gcloud prompts for confirmation before deleting rules, failing the e2e suite on local runs. This PR also adds checks for a default compute/region setting, without which gcloud will fail even with -q because it doesn't know which region to use.