Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bootstrap policy for HPA metrics REST clients #52572

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Add bootstrap policy for HPA metrics REST clients #52572

merged 1 commit into from
Sep 16, 2017
+21 −2

Conversation

DirectXMan12
Copy link
Contributor

Since we weren't running the HPA with metrics REST clients by default,
we had no bootstrap policy enabling the HPA controller to talk to the
metrics APIs.

This adds permissions for the HPA controller to talk list
pods.metrics.k8s.io, and list any resource in custom.metrics.k8s.io.

Introduce policy to allow the HPA to consume the metrics.k8s.io and custom.metrics.k8s.io API groups.

@DirectXMan12
Add bootstrap policy for HPA metrics REST clients
8cbbbac 
Since we weren't running the HPA with metrics REST clients by default,
we had no bootstrap policy enabling the HPA controller to talk to the
metrics APIs.

This adds permissions for the HPA controller to talk list
pods.metrics.k8s.io, and list any resource in custom.metrics.k8s.io.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2017
@DirectXMan12
Copy link
Contributor Author

cc @kubernetes/sig-autoscaling-pr-reviews
cc @kubernetes/kubernetes-release-managers this is some missing policy that should have been in place a while ago, but didn't actually get tested for various reasons. I caught it as part of #52553, but figured it deserved its own PR just in case the other did not get accepted

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Sep 15, 2017
@ericchiang
Copy link
Contributor

At first glance this appears to overlaps with #52553 is there a reason there are two PRs open?

@DirectXMan12
Copy link
Contributor Author

@ericchiang this should get accepted into the release in either case -- it's a simple case of missing policy. I wasn't sure if the other one (#52553) would get accepted this late into the release (because it's a "if you have an existing setup and don't do the upgrade properly you'll break your HPA"), so I figured this should have a stand-alone PR just in case

@ericchiang ericchiang mentioned this pull request Sep 15, 2017
Closed
@ericchiang ericchiang added this to the v1.8 milestone Sep 15, 2017
@liggitt
Copy link
Member

liggitt commented Sep 16, 2017

/retest

@ericchiang
Copy link
Contributor

Role changes lgtm (assuming they've been tested)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2017
@luxas
Copy link
Member

luxas commented Sep 16, 2017

/assign @liggitt
for approval

@liggitt
Copy link
Member

liggitt commented Sep 16, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DirectXMan12, ericchiang, liggitt

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@luxas luxas added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

1 similar comment
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 8163d14 into kubernetes:master Sep 16, 2017
@DirectXMan12 DirectXMan12 deleted the bug/fix-missing-hpa-metrics-policy branch September 18, 2017 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@ericchiang ericchiang

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@DirectXMan12 @ericchiang @liggitt @luxas @k8s-github-robot @deads2k @k8s-ci-robot