Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable autoscaling/v2beta1 by default #52549

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Enable autoscaling/v2beta1 by default #52549

merged 1 commit into from
Sep 19, 2017

Conversation

DirectXMan12
Copy link
Contributor

The PR which graduated autoscaling/v2alpha1 to beta accidentally
missed enabling the API group by default. This rectifies that.

Release note:

The autoscaling/v2beta1 API group is now enabled by default.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2017
@DirectXMan12
Copy link
Contributor Author

/cc @piosz @luxas

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2017
@k8s-ci-robot k8s-ci-robot requested review from luxas and piosz September 15, 2017 15:04
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2017
@piosz piosz self-assigned this Sep 15, 2017
@piosz
Copy link
Member

piosz commented Sep 15, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2017
@DirectXMan12 DirectXMan12 force-pushed the feature/enable-hpa-v2-by-default branch 2 times, most recently from c62a06d to 871a297 Compare September 15, 2017 15:12
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2017
@DirectXMan12
Copy link
Contributor Author

(would help if I actually had the right import ;-) )

@DirectXMan12
Enable autoscaling/v2beta1 by default
fd2a5ee 
The PR which graduated autoscaling/v2alpha1 to beta accidentally
missed enabling the API group by default.  This rectifies that.
@DirectXMan12 DirectXMan12 force-pushed the feature/enable-hpa-v2-by-default branch from 871a297 to fd2a5ee Compare September 15, 2017 15:28
@luxas luxas added this to the v1.8 milestone Sep 15, 2017
luxas
luxas approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2017
@luxas
Copy link
Member

luxas commented Sep 15, 2017

/retest
cc @kubernetes/sig-autoscaling-pr-reviews @kubernetes/sig-api-machinery-pr-reviews
FYI @kubernetes/kubernetes-release-managers this needs to get into v1.8, was an oversight in the earlier PR(s)

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 15, 2017
@sttts
Copy link
Contributor

sttts commented Sep 18, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, luxas, piosz, sttts

Associated issue requirement bypassed by: sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@luxas
Copy link
Member

luxas commented Sep 18, 2017 via email

@lavalamp lavalamp removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 18, 2017
@lavalamp
Copy link
Member

Removing the sig/api-machinery label: SIG API Machinery doesn't own the contents of the API.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48970, 52497, 51367, 52549, 52541). If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 86cebde into kubernetes:master Sep 19, 2017
@DirectXMan12 DirectXMan12 deleted the feature/enable-hpa-v2-by-default branch September 19, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

@piosz piosz Awaiting requested review from piosz

Assignees

@sttts sttts

@mikedanese mikedanese

@luxas luxas

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
9 participants
@DirectXMan12 @piosz @luxas @sttts @k8s-github-robot @lavalamp @fejta-bot @mikedanese @k8s-ci-robot