Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker caching support to CoreOS' clusters. #5254

Conversation

AntonioMeireles
Copy link
Contributor

a more idiomatic take on #4378. as a bonus, and to be nice on
resources, an ultra lightweight docker-registry container is
consumed.

@nikhiljindal
Copy link
Contributor

@brendandburns : Are you the right person to assign this to?

@erictune
Copy link
Member

fyi @pires

@pires
Copy link
Contributor

pires commented Mar 11, 2015

@erictune I favor this one instead of my old #4378. LGTM

@AntonioMeireles
Copy link
Contributor Author

guys, i've appended an extra patchlet to simplify fleet's instrumentation. IMHO, it also would make sense to handle flannels' invocation in a similar way (taking advantage of what already ships nativelly) and just consume the (units in) currently shipping CoreOS. So, is there any good reason to be using the blob at https://storage.googleapis.com/k8s/flanneld instead of the upstream bits shipping in plain CoreOS ? (fwiw in the kubernetes-vagrant-coreos-cluster project we've been using plain upstream flannel without any (obvious) issues ).

@AntonioMeireles AntonioMeireles force-pushed the add_docker_caching_to_CoreOS_cluster branch 2 times, most recently from 2a515d7 to 67ee10d Compare March 12, 2015 16:08
    a more idiomatic take on kubernetes#4378. as a bonus, and to be nice on
    resources, an ultra lightweight docker-registry container is
    consumed.

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
Signed-off-by: António Meireles <antonio.meireles@reformi.st>
@AntonioMeireles AntonioMeireles force-pushed the add_docker_caching_to_CoreOS_cluster branch from 67ee10d to b5a50ca Compare March 13, 2015 09:52
@brendandburns
Copy link
Contributor

Looks good to me. merging.

(the reason we use the blob in google storage is idempotentcy of deploy, but given that we haven't updated it in a while, I'm ok with relying on the CoreOS version)

brendandburns added a commit that referenced this pull request Mar 13, 2015
…oreOS_cluster

Add Docker caching support to CoreOS' clusters.
@brendandburns brendandburns merged commit 5326bae into kubernetes:master Mar 13, 2015
@AntonioMeireles AntonioMeireles deleted the add_docker_caching_to_CoreOS_cluster branch March 13, 2015 19:22
AntonioMeireles added a commit to AntonioMeireles/kubernetes that referenced this pull request Mar 17, 2015
in the footsteps of kubernetes#5254 merge earlier today and per @brendandburns comments
in the PR review thread...

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
akram pushed a commit to akram/kubernetes that referenced this pull request Apr 7, 2015
in the footsteps of kubernetes#5254 merge earlier today and per @brendandburns comments
in the PR review thread...

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants