-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SkyDNS version #5238
Update SkyDNS version #5238
Conversation
I'm running kubernetes on CoreOS in a vagrant cluster on my local machine. |
@rsokolowski can you rebuild our custom ultra-minimal skydns container too? |
@@ -35,7 +35,7 @@ desiredState: | |||
"-domain={{ pillar['dns_domain'] }}", | |||
] | |||
- name: skydns | |||
image: kubernetes/skydns:2014-12-23-001 | |||
image: skynetservices/skydns:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using a new versioned image rather than tracking latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, unless they have fixed the SkyDNS container to not be 600 MB, we should keep using our own build. @bketelsen have you guys "fixed" that yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but I didn't see any tagged versions in the SkyDns docker repo and I wasn't aware of the size issue. Happy to update this if someone creates an updated, tagged image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use kubernetes/skydns:2015-03-11-001 instead.
@rsokolowski until you say stop, I'm going to send all these DNS related issues your way :) |
I can do it. Done. |
I had some trouble with the kubernetes docker image for SkyDNS being outdated. In my experience the version in `kubernetes/skydns:2014-12-23-001` will not behave correctly if it manages to startup before etcd, for details see skynetservices/skydns#142 Updating to SkyDNS latest fixes this.
Image updated to |
LGTM. Will merge during merge hours. |
I had some trouble with the kubernetes docker image for SkyDNS being outdated. In my experience the version in
kubernetes/skydns:2014-12-23-001
will not behave correctly if it manages to startup before etcd, for details see skynetservices/skydns#142Updating to SkyDNS latest fixes this.