Added support for labels to "kubectl stop". #5237
Merged
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piosz
added
the
lgtm
| @@ -46,7 +49,7 @@ func (f *Factory) NewCmdStop(out io.Writer) *cobra.Command { | |||
| Filenames util.StringList | |||
| }{} | |||
| cmd := &cobra.Command{ | |||
| Use: "stop (<resource> <id>|-f filename)", | |||
| Use: "stop (<resource> (<id> | -l <label> | --all) | -f filename)", | |||
There was a problem hiding this comment.
Please make the usage message consistent with delete:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubectl/cmd/delete.go#L63
bgrant0607
removed
the
lgtm
Added support for labels and --all to "kubectl stop". Fixes kubernetes#5178.
jszczepkowski
force-pushed
the
stop-labels
branch
from
7d5463e to
110ab79
Compare
|
Use string for stop made consistent with delete; use string for delete set straight. PTAL |
|
LGTM. |
bgrant0607
added a commit
that referenced
this pull request
Mar 11, 2015
Added support for labels to "kubectl stop".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for filtering resources by labels and --all to "kubectl stop". Fixes #5178.