Fix deployment timeout reporting #52127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kargakis Associated issue: 49637 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
approved
This was referenced Sep 8, 2017
kow3ns
reviewed
Sep 8, 2017
| // cached copy of the Deployment getting updated with the status.condition that indicates | ||
| // the creation of the new ReplicaSet. | ||
| // | ||
| // In that case, we are going to falsely indicate that the Deployment has failed syncing. |
There was a problem hiding this comment.
The last line of this comment is a little unclear
There was a problem hiding this comment.
Thanks, now that I am reading it again, indeed it is. Updated.
If the previous condition has been a successful rollout then we shouldn't try to estimate any progress. Scenario: * progressDeadlineSeconds is smaller than the difference between now and the time the last rollout finished in the past. * the creation of a new ReplicaSet triggers a resync of the Deployment prior to the cached copy of the Deployment getting updated with the status.condition that indicates the creation of the new ReplicaSet. The Deployment will be resynced and eventually its Progressing condition will catch up with the state of the world. Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
0xmichalis
added
the
lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Sep 11, 2017
Automatic merge from submit-queue UPSTREAM: 52127: Fix deployment timeout reporting If the previous condition has been a successful rollout then we shouldn't try to estimate any progress. Scenario: * progressDeadlineSeconds is smaller than the difference between now and the time the last rollout finished in the past. * the creation of a new ReplicaSet triggers a resync of the Deployment prior to the cached copy of the Deployment getting updated with the status.condition that indicates the creation of the new ReplicaSet. The Deployment will be resynced and eventually its Progressing condition will catch up with the state of the world. Signed-off-by: Michail Kargakis <mkargaki@redhat.com> Cherry-pick of kubernetes/kubernetes#52127 /assign @mfojtik @tnozicka /area apps /kind bug
wojtek-t
added
cherry-pick-approved
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 16, 2017
Automatic merge from submit-queue. Fix deployment timeout reporting If the previous condition has been a successful rollout then we shouldn't try to estimate any progress. Scenario: * progressDeadlineSeconds is smaller than the difference between now and the time the last rollout finished in the past. * the creation of a new ReplicaSet triggers a resync of the Deployment prior to the cached copy of the Deployment getting updated with the status.condition that indicates the creation of the new ReplicaSet. The Deployment will be resynced and eventually its Progressing condition will catch up with the state of the world. Signed-off-by: Michail Kargakis <mkargaki@redhat.com> Cherry-pick of #52127 to 1.7 Fixes #49637 @kubernetes/sig-apps-pr-reviews ```release-note Fixed an issue reporting lack of progress for a deployment prematurely ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the previous condition has been a successful rollout then we
shouldn't try to estimate any progress. Scenario:
now and the time the last rollout finished in the past.
Deployment prior to the cached copy of the Deployment getting
updated with the status.condition that indicates the creation
of the new ReplicaSet.
The Deployment will be resynced and eventually its Progressing
condition will catch up with the state of the world.
Fixes #49637
I will also cherry-pick this back to 1.7.
Release note: