Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Soft Eviction timer works correctly #52046

Merged
merged 1 commit into from
Sep 13, 2017
Merged

[BugFix] Soft Eviction timer works correctly #52046

merged 1 commit into from
Sep 13, 2017

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 6, 2017 •
edited
Loading

fixes #51516

thresholdsMet should not exclude previously met thresholds when we do not have new stats for a threshold.

/assign @vishh @derekwaynecarr
cc @kubernetes/sig-node-bugs

Fix a bug where soft eviction would not trigger when the threshold was crossed

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 6, 2017
@vishh
Copy link
Contributor

vishh commented Sep 6, 2017

/lgtm
/approve

Should this be cherrypicked into older releases? @derekwaynecarr please advice on the priority.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2017
@vishh vishh added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, vishh

Associated issue: 51516

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2017
@dchen1107
Copy link
Member

Thanks for the fix.

@dashpole dashpole changed the title Soft Eviction timer works correctly [BugFix] Soft Eviction timer works correctly Sep 6, 2017
@dashpole
Copy link
Contributor Author

dashpole commented Sep 6, 2017

This will need the 1.8 milestone if we want to get this in. I think it would also be good to cherrypick this to 1.7.

@Kooper
Copy link

Kooper commented Sep 7, 2017

Please backport this into 1.7 branch, we definitively need the problem to be fixed in order to upgrade our production cluster.

Moreover, do we have any chances to fix it in 1.6? The bug prevents us from gradually upgrading production from 1.5

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@vishh vishh added this to the v1.8 milestone Sep 13, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48226, 52046, 52231, 52344, 52352)

@k8s-github-robot k8s-github-robot merged commit 32f1521 into kubernetes:master Sep 13, 2017
@dashpole dashpole deleted the soft_eviction branch September 20, 2017 20:43
@dashpole
Copy link
Contributor Author

can we add the cherrypick-candidate label to this, and set the milestone to 1.7?

@rvadim
Copy link

rvadim commented Sep 25, 2017

@vishh we need this fix for 1.7, can we add proper labels?

@djsly
Copy link
Contributor

djsly commented Nov 13, 2017

as this ever cherry picked in 1.7 ?

@dashpole dashpole mentioned this pull request Nov 13, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2017
Merge pull request #55625 from dashpole/automated-cherry-pick-of-#520…
1cfda8d 
…46-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #52046

Cherry pick of #52046 on release-1.7.

#52046: soft eviction timer works
@ahakanbaba
Copy link
Contributor

Can this be cherry-picked to 1.6 too ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

kubelet 1.6.4 not deleting unused images when eviction-soft imagefs threshold met