Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COS/GCE: bump the max pids for the docker service #51986

Merged
merged 1 commit into from
Sep 6, 2017
Merged

COS/GCE: bump the max pids for the docker service #51986

merged 1 commit into from
Sep 6, 2017

Conversation

yujuhong
Copy link
Contributor

@yujuhong yujuhong commented Sep 5, 2017 •
edited by enisoc
Loading

What this PR does / why we need it:
TasksMax limits how many threads/processes docker can create. Insufficient limit affects container starts.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #51977

Special notes for your reviewer:

Release note:

In GCE with COS, increase TasksMax for Docker service to raise cap on number of threads/processes used by containers.

@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 5, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2017
@yujuhong yujuhong added this to the v1.8 milestone Sep 5, 2017
dchen1107
dchen1107 reviewed Sep 5, 2017
View reviewed changes
cluster/gce/gci/configure-helper.sh Outdated
mkdir -p /etc/systemd/system/docker.service.d
cat <<EOF >/etc/systemd/system/docker.service.d/02tasksmax.conf
[Service]
TasksMax=10000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this even bigger, something like 1048600?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current number 4915 is the "15% of "max number of tasks on the system" according to the COS team. How about setting it to infinity (i.e., no limit)?

@dchen1107
Copy link
Member

dchen1107 commented Sep 5, 2017 •
edited
Loading

@yujuhong We might have to cherrypick this back to 1.6 and 1.7.

cc/ @wojtek-t @enisoc

@yujuhong
COS/GCE: Ensure TasksMax is sufficient for docker
d6de90e 
This affects how many threads/processes docker can create, and should
not be limited.
@yujuhong
Copy link
Contributor Author

yujuhong commented Sep 5, 2017

Updated the PR.

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yujuhong

Associated issue: 51977

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 5, 2017 •
edited
Loading

@yujuhong: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws d6de90e link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yujuhong
Copy link
Contributor Author

yujuhong commented Sep 5, 2017

/test pull-kubernetes-unit

@Random-Liu
Copy link
Member

LGTM

This was referenced Sep 6, 2017
Merged
Merged
@yujuhong yujuhong added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 6, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51921, 51829, 51968, 51988, 51986)

@k8s-github-robot k8s-github-robot merged commit fa916c1 into kubernetes:master Sep 6, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Sep 6, 2017

Cherrypick for 1.7 approved.

@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2017
k8s-github-robot pushed a commit that referenced this pull request Sep 6, 2017
Merge pull request #51992 from yujuhong/automated-cherry-pick-of-#519…
39ae9e5 
…86-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #51986

Cherry pick of #51986 on release-1.6.

#51986: COS/GCE: Ensure TasksMax is sufficient for docker
k8s-github-robot pushed a commit that referenced this pull request Sep 7, 2017
Merge pull request #51991 from yujuhong/automated-cherry-pick-of-#519…
1a09ac0 
…86-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #51986

Cherry pick of #51986 on release-1.7.

#51986: COS/GCE: Ensure TasksMax is sufficient for docker
@yujuhong yujuhong deleted the docker-pids branch September 11, 2017 20:31
justinsb added a commit to justinsb/kops that referenced this pull request Jun 3, 2018
@justinsb
docker: Set TasksMax to infinity
088d14e 
Equivalent of kubernetes/kubernetes#51986
@justinsb justinsb mentioned this pull request Jun 3, 2018
Merged
justinsb added a commit to justinsb/kops that referenced this pull request Jun 4, 2018
@justinsb
docker: Set TasksMax to infinity
465ab22 
Equivalent of kubernetes/kubernetes#51986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 dchen1107 left review comments

Assignees

@Random-Liu Random-Liu

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

COS m60 set low pids limit for docker.
7 participants
@yujuhong @dchen1107 @k8s-github-robot @k8s-ci-robot @Random-Liu @wojtek-t @abgworrall