Build test targets for all server platforms #51873
Conversation
k8s-ci-robot
added
size/XS
k8s-github-robot
added
the
release-note
k8s-ci-robot
added
size/S
| @@ -33,6 +33,10 @@ import ( | |||
| "k8s.io/client-go/dynamic" | |||
| ) | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
why this change part of this PR?
There was a problem hiding this comment.
otherwise arm 32 bit fails due to that the constant is larger than int32 (default on arm) can handle
|
/retest |
|
/lgtm though we should probably start breaking up |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ixdy, luxas Assign the PR to them by writing Associated issue: 288 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
(also note you only need to build the test binaries for architectures you're launching tests from - e.g. if I have a cluster running on arm, but my workstation is amd64, I don't need to build the test binaries for arm.) |
|
/test pull-kubernetes-cross |
@ixdy Yeah, I know, but this is required as we're starting to run e2es on Packet ARM servers; where the e2e binaries are running in-cluster => cross-built e2e binaries are needed.
Can you please open an issue with more info about that so we can target it for v1.9? |
|
/test pull-kubernetes-e2e-kops-aws |
| linux/arm | ||
| linux/arm64 | ||
| linux/s390x | ||
| linux/ppc64le |
There was a problem hiding this comment.
will this cause any build performance regressions?
There was a problem hiding this comment.
no, this is for release (and the post-ci, independently running kube-cross job) code only. All other jobs etc perform the "fast path" and only build for amd64
|
Adding the approved label as the release team and @ixdy were happy with the changes here, and we want to get this in for tomorrow's beta.1 |
luxas
added
the
approved
|
/retest |
|
/retest Review the full test history for this PR. |
|
@luxas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 51984, 51351, 51873, 51795, 51634) |
|
@luxas could you please assign a SIG label to this? Thanks! |
luxas
added
the
sig/release
|
@jdumars added |
What this PR does / why we need it:
🤦
I really should have checked this before code freeze, but tbh forgot it in the rush. Also I thought this was the case already...
As part of kubernetes/enhancements#288; these binaries should be built for all server platforms indeed.
This is just a straightforward add to that list.
Can we please get this into v1.8?
There is virtually no risk involved here really...
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note:
@ixdy @jdumars @mkumatag