Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workloads deprecation 1.8 #51828

Merged
merged 2 commits into from
Sep 3, 2017
Merged

Workloads deprecation 1.8 #51828

merged 2 commits into from
Sep 3, 2017

Conversation

kow3ns
Copy link
Member

@kow3ns kow3ns commented Sep 1, 2017

What this PR does / why we need it: This PR deprecates the Deployment, ReplicaSet, and DaemonSet kinds in the extensions/v1beta1 group version and the StatefulSet, Deployment, and ControllerRevision kinds in the apps/v1beta1 group version. The Deployment, ReplicaSet, DaemonSet, StatefuSet, and ControllerRevision kinds in the apps/v1beta2 group version are now the current version.

xref kubernetes/enhancements#353

The Deployment, DaemonSet, and ReplicaSet kinds in the extensions/v1beta1 group version are now deprecated, as are the Deployment, StatefulSet, and ControllerRevision kinds in apps/v1beta1. As they will not be removed until after a GA version becomes available, you may continue to use these kinds in existing code. However, all new code should be developed against the apps/v1beta2 group version.

Kenneth Owens added 2 commits September 1, 2017 14:24
Deprecates extension/v1beta DaemonSet Deployment and ReplicaSet
e71f999 
Deprecates apps/v1beta1 Deployment StatefulSet and ControllerRevision
auto generated
5d9748b
@kow3ns kow3ns requested a review from thockin September 1, 2017 21:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2017
@kow3ns kow3ns requested a review from bgrant0607 September 1, 2017 21:40
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 1, 2017
@david-mcmahon david-mcmahon removed their assignment Sep 1, 2017
@foxish
Copy link
Contributor

foxish commented Sep 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
@thockin
Copy link
Member

thockin commented Sep 1, 2017

/lgtm
/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxish, kow3ns, thockin

Associated issue: 353

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@abgworrall abgworrall modified the milestone: v1.8 Sep 2, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

krmayankk
krmayankk reviewed Sep 3, 2017
View reviewed changes
api/openapi-spec/swagger.json
@@ -54887,7 +54887,7 @@
]
},
"io.k8s.api.apps.v1beta1.Deployment": {
"description": "Deployment enables declarative updates for Pods and ReplicaSets.",
"description": "DEPRECATED - This group version of Deployment is deprecated by apps/v1beta2/Deployment. See the release notes for more information. Deployment enables declarative updates for Pods and ReplicaSets.",
Copy link

@krmayankk krmayankk Sep 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the keyword DEPRECATED have a special significance ? I mean is there tooling to consume it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users consume it from API docs, e.g. https://kubernetes.io/docs/api-reference/v1.7/ or kubectl explain

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@kow3ns
Copy link
Member Author

kow3ns commented Sep 3, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 52b50fa into kubernetes:master Sep 3, 2017
@k8s-ci-robot
Copy link
Contributor

@kow3ns: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 5d9748b link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce-bazel 5d9748b link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janetkuo janetkuo mentioned this pull request Sep 5, 2017
Closed
@jdumars
Copy link
Member

jdumars commented Sep 6, 2017

@kow3ns could please add a SIG label? Thanks!

@dhilipkumars dhilipkumars mentioned this pull request Nov 14, 2017
Closed
4 tasks
@alexbrand alexbrand mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmayankk krmayankk krmayankk left review comments

@janetkuo janetkuo janetkuo left review comments

@thockin thockin Awaiting requested review from thockin

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

Assignees

@foxish foxish

@thockin thockin

@therc therc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.