Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated init-container in annotations #51816

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Remove deprecated init-container in annotations #51816

merged 2 commits into from
Sep 4, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 1, 2017 •
edited
Loading

fixes #50655
closes #41004
fixes #47264

Builds on #50654 and drops the initContainer annotations on conversion to prevent bypassing API server validation/security and targeting version-skewed kubelets that still honor the annotations

The deprecated alpha and beta initContainer annotations are no longer supported. Init containers must be specified using the initContainers field in the pod spec.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2017
@liggitt liggitt mentioned this pull request Sep 1, 2017
Closed
@liggitt liggitt added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 1, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 1, 2017
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 1, 2017
@liggitt liggitt added this to the v1.8 milestone Sep 1, 2017
@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

Associated issue: 50655

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@xiangpengzhao
Copy link
Contributor

@liggitt sorry for the delay in #50654. Thanks for the following commit! 😄

@xiangpengzhao
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 4, 2017 •
edited
Loading

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 525254a link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6ec80ea into kubernetes:master Sep 4, 2017
@liggitt liggitt deleted the xiangpengzhao-remove-initc-anno branch September 4, 2017 14:58
@xiangpengzhao
Copy link
Contributor

@liggitt one newbie question on git: how to combine an unmerged commit into my branch from other's branch? Thanks! I see you did this in this PR.

@liggitt
Copy link
Member Author

liggitt commented Sep 6, 2017 •
edited
Loading

fetch the PR branch locally, check it out, add additional commits, then push to your own fork and open the PR (in this example, the kubernetes remote is named upstream and my fork is named origin):

git fetch upstream pull/50654/head:my-branch
git checkout my-branch
... do work, make additional commits ...
git push -u origin

also, https://github.com/github/hub makes it super easy to check out pull requests as git checkout https://github.com/kubernetes/kubernetes/pull/51816

@xiangpengzhao
Copy link
Contributor

@liggitt awesome, thanks!

This was referenced Sep 6, 2017
Closed
Closed
@liggitt liggitt mentioned this pull request Sep 6, 2017
Closed
@zmerlynn zmerlynn mentioned this pull request Sep 6, 2017
Closed
@liggitt liggitt mentioned this pull request Sep 9, 2017
Closed
@sjenning sjenning mentioned this pull request Sep 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
5 participants
@liggitt @smarterclayton @k8s-github-robot @xiangpengzhao @k8s-ci-robot