Introducing metrics-server #51792
Introducing metrics-server #51792
Conversation
k8s-ci-robot
added
size/L
k8s-github-robot
added
the
release-note
|
/test pull-kubernetes-unit |
|
/test pull-kubernetes-e2e-gce-etcd3 |
|
/test pull-kubernetes-kubemark-e2e-gce |
piosz
force-pushed
the
metrics-server
branch
from
eb8484a to
a8beed9
Compare
|
/test pull-kubernetes-federation-e2e-gce |
|
/test pull-kubernetes-kubemark-e2e-gce |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: system:auth-delegator |
There was a problem hiding this comment.
this looks find but cc @deads2k
There was a problem hiding this comment.
this was reviewed in kubernetes-sigs/metrics-server#4
There was a problem hiding this comment.
this looks find but cc @deads2k
That's the role name. It allows the caller to hit tokenaccessreviews and subjectaccessreviews.
|
/approve |
piosz
removed
the
lgtm
|
removed lgtm label to let @DirectXMan12 to take a look |
k8s-github-robot
added
the
approved
|
looks fine at a glance. Will take a closer look a bit later if need be. metrics-server needs to be updated to use metrics.k8s.io/v1beta1, otherwise it won't work once the resource metrics API update merges, though. |
|
@DirectXMan12 will update this once #51653 is merged. It's currently not used by HPA so it's safe to merge it. |
| command: | ||
| - /metrics-server | ||
| - --source=kubernetes.summary_api:'' | ||
| tolerations: |
There was a problem hiding this comment.
Please list ports here
| # this in case of stability issues. | ||
| # TODO(piosz) remove this option once Metrics Server became a stable thing. | ||
| ENABLE_METRICS_SERVER="${KUBE_ENABLE_METRICS_SERVER:-true}" | ||
|
|
There was a problem hiding this comment.
If this is going to be enabled by default, we should be using it for something, and should not deploy (or at least warn about) Heapster. Turn it on in a separate PR once we're ready to make the HPA use it by default.
There was a problem hiding this comment.
I'd like to switch HPA in 1.8 to use metrics server.
Heapster is used by dashboard. Also we should perform a graceful switch and have both metrics-server and Heapster enabled in one release (1.8).
piosz
force-pushed
the
metrics-server
branch
from
a8beed9 to
f939111
Compare
|
@DirectXMan12 comments addressed. PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mikedanese, piosz Associated issue: 271 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Review the full test history for this PR. |
1 similar comment
|
/retest Review the full test history for this PR. |
|
/test pull-kubernetes-e2e-kops-aws |
1 similar comment
|
/test pull-kubernetes-e2e-kops-aws |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test pull-kubernetes-e2e-gce-etcd3 |
|
/test pull-kubernetes-e2e-kops-aws |
|
Automatic merge from submit-queue (batch tested with PRs 49727, 51792) |
|
@piosz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@piosz could you please add a SIG label? Thanks! |
luxas
added
the
sig/instrumentation
ref kubernetes/enhancements#271
There is still some work blocked on problems with repo synchronization:
v1beta1introduced in Graduate metrics/v1alpha1 to v1beta1 #51653Will do it in a follow up PRs once the issue is resolved.