Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage in master. #5159

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Conversation

brendandburns
Copy link
Contributor

No description provided.

@brendandburns brendandburns force-pushed the coverage branch 2 times, most recently from fedbed6 to fb0f76c Compare March 7, 2015 11:54
@alex-mohr
Copy link
Contributor

Yay, better tests!

@alex-mohr alex-mohr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2015
alex-mohr added a commit that referenced this pull request Mar 9, 2015
Expand test coverage in master.
@alex-mohr alex-mohr merged commit 37bfb0d into kubernetes:master Mar 9, 2015
@satnam6502
Copy link
Contributor

Has this broken our build?

--- FAIL: TestReadConfigData (0.73s)
    helpers_test.go:259: unexpected non-error for http://some.non.existent.url

@brendandburns
Copy link
Contributor Author

Travis is still green...

https://travis-ci.org/GoogleCloudPlatform/kubernetes/builds

I will try to repro at head.

@brendandburns
Copy link
Contributor Author

ok, I can repro this on my machine, will investigate more. I'm guessing some sort of Google network weirdness.

@brendandburns
Copy link
Contributor Author

it's the .url TLD. Switching to something even more bogus.

@satnam6502
Copy link
Contributor

Happy to debug and fix if you don't have the time.

@brendandburns
Copy link
Contributor Author

See:
#5199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants